Remove MP3 preprocessing#44
Merged
Merged
Conversation
Remove the MP3 preprocessing phase that removes the ID3v2 tag from the preloaded file before playback. This preprocessing was introduced a long time ago because the Windows audio backend (DirectShow) failed to play MP3 files that had an ID3v2.4 tag. This workaround should no longer be necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the MP3 preprocessing phase that removes the ID3v2 tag from the preloaded file before playback. This preprocessing was introduced a long time ago because the Windows audio backend that was used by Qt back then (DirectShow) failed to play MP3 files that contained an ID3v2.4 tag. This workaround should no longer be necessary.